Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add conditional arg for predict #438

Merged
merged 11 commits into from
Apr 24, 2024
Merged

add conditional arg for predict #438

merged 11 commits into from
Apr 24, 2024

Conversation

clarkliming
Copy link
Collaborator

close #437

allow unconditioanl prediction

@danielinteractive danielinteractive added this to PR To review (high priority!) in mmrm package board via automation Apr 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 22, 2024 •
edited
Loading

Unit Tests Summary

    1 files     46 suites   24s ⏱️
  498 tests   460 ✅ 38 💤 0 ❌
1 905 runs  1 863 ✅ 42 💤 0 ❌

Results for commit dbafb8c.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 22, 2024 •
edited
Loading

Unit Test Performance Difference

Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
tmb-methods 👶 $+0.02$ predict_can_change_based_on_coefficients
tmb-methods 👶 $+0.02$ predict_can_give_unconditional_predictions
tmb-methods 👶 $+0.04$ predict_can_work_if_response_is_an_expression
tmb-methods 👶 $+0.05$ simulate_works_if_the_model_reponse_is_an_expression
utils 👶 $+0.01$ h_factor_ref_data_works

Results for commit e8dcae5

♻️ This comment has been updated with latest results.

danielinteractive
danielinteractive reviewed Apr 22, 2024
View reviewed changes
R/tmb-methods.R Outdated Show resolved Hide resolved
danielinteractive
danielinteractive reviewed Apr 22, 2024
View reviewed changes
R/tmb-methods.R Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 22, 2024 •
edited
Loading

badge

Code Coverage Summary

Filename                    Stmts    Miss  Cover    Missing
------------------------  -------  ------  -------  ----------------------------
R/between-within.R             59       0  100.00%
R/component.R                  67       0  100.00%
R/cov_struct.R                 97       1  98.97%   407
R/empirical.R                   7       0  100.00%
R/fit.R                       229       3  98.69%   420, 481, 511
R/interop-car.R                72       3  95.83%   9, 48, 68
R/interop-emmeans.R            39       0  100.00%
R/interop-parsnip.R            59       1  98.31%   12
R/kenwardroger.R               92       2  97.83%   41, 63
R/mmrm-methods.R              140       0  100.00%
R/residual.R                    8       0  100.00%
R/satterthwaite.R             116      12  89.66%   238-249
R/skipping.R                    8       0  100.00%
R/testing.R                    64       4  93.75%   29, 31, 80, 82
R/tidiers.R                    72       2  97.22%   46-47
R/tmb-methods.R               281       3  98.93%   278-279, 339
R/tmb.R                       281       0  100.00%
R/utils-formula.R              27       0  100.00%
R/utils-nse.R                  16       0  100.00%
R/utils.R                     193      12  93.78%   279-289, 485, 514
R/zzz.R                        70      24  65.71%   7-22, 55-60, 90, 118, 138
src/chol_cache.h               63       0  100.00%
src/covariance.h              101       1  99.01%   177
src/derivatives.h             126       0  100.00%
src/empirical.cpp              72       0  100.00%
src/exports.cpp                47       0  100.00%
src/jacobian.cpp               47       1  97.87%   54
src/kr_comp.cpp                56       0  100.00%
src/mmrm.cpp                   76       0  100.00%
src/predict.cpp                93       0  100.00%
src/test-chol_cache.cpp        58       5  91.38%   9, 18, 26, 55, 62
src/test-covariance.cpp       123       5  95.93%   9, 29, 40, 61, 72
src/test-derivatives.cpp      108       7  93.52%   44, 53, 62, 85, 94, 106, 124
src/test-utils.cpp            195       7  96.41%   9, 16, 24, 34, 44, 57, 119
src/testthat-helpers.h         15       5  66.67%   36-37, 41, 50, 53
src/utils.h                    78       0  100.00%
TOTAL                        3255      98  96.99%

Diff against main

Filename           Stmts    Miss  Cover
---------------  -------  ------  -------
R/tmb-methods.R       -7       0  -0.03%
R/utils.R             +8       0  +0.27%
TOTAL                 +1       0  +0.00%

Results for commit: dbafb8c

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

danielinteractive
danielinteractive reviewed Apr 23, 2024
View reviewed changes
Copy link
Collaborator

@danielinteractive danielinteractive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @clarkliming , last comments, I promise :-)

R/tmb.R Outdated Show resolved Hide resolved
R/utils.R Outdated Show resolved Hide resolved
danielinteractive
danielinteractive approved these changes Apr 24, 2024
View reviewed changes
Copy link
Collaborator

@danielinteractive danielinteractive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot Liming

R/utils.R Show resolved Hide resolved
@clarkliming clarkliming merged commit 239fe10 into main Apr 24, 2024
23 checks passed
mmrm package board automation moved this from PR To review (high priority!) to Done Apr 24, 2024
@clarkliming clarkliming deleted the 437_marginaleffects branch April 24, 2024 07:19
@danielinteractive danielinteractive mentioned this pull request Apr 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielinteractive danielinteractive danielinteractive approved these changes

Assignees
No one assigned
Labels
None yet
Projects
mmrm package board
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support for {marginaleffects}
2 participants
@clarkliming @danielinteractive